fix: allow programRuleAction translations [DHIS2-12971] #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-848--dhis2-translations.netlify.app |
kabaros
approved these changes
Dec 14, 2023
|
🎉 This PR is included in version 26.2.49 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
tomzemp
added a commit
that referenced
this pull request
Dec 15, 2023
tomzemp
added a commit
that referenced
this pull request
Dec 15, 2023
tomzemp
added a commit
that referenced
this pull request
Dec 15, 2023
This was referenced Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://dhis2.atlassian.net/browse/DHIS2-12971
In general, we filter items for translation based on name (and also show that name in the card for each object available to translate). However, programRuleActions do not have names, and the only translatable property is
content.I have added in some logic that lets us override
nameas the default property for search/card title so that programRuleActions can appear in the app.Before
Doesn't load, you get a snackbar warning of
Cannot read properties of undefined (reading 'trim')After
